This repository was archived by the owner on Mar 12, 2021. It is now read-only.
Add deterministic option #465
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maleadt Any comments on this? |
|
This seems like a good idea, but I think we could do a slightly different setup:
How does that sound? |
|
@MikeInnes I introduced the global variable for determinism and replaced assertions with warnings when not deterministic. |
MikeInnes
reviewed
Jan 10, 2020
|
Looks fine to me, thanks. Would like a thumbs up from @maleadt. |
Co-Authored-By: Mike J Innes <[email protected]>
|
I'm not against the feature, but I worry it will not be maintained and thus the determinism promise won't mean much. At the least needs some tests though, and it might be easier to test if the warning were just an error. |
maleadt
force-pushed
the
master
branch
2 times, most recently
from
fc487fd to
fced436
Compare
Sure I will add some tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the commonly used kernels (conv and maxpool) are not deterministic by default. This hurts reproducibility a lot - when fix random seed (e.g. by
seed!(1)) users cannot reproduce the results.I added an option to provide default and check if a mode/algo is deterministic.